Skip to content

Commit

Permalink
Update RemainingInvalidatorLib.sol
Browse files Browse the repository at this point in the history
changed remaining amount representation in RemainInvalidator
  • Loading branch information
galekseev committed Jul 11, 2023
1 parent d30ad2d commit ca99b4c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions contracts/libraries/RemainingInvalidatorLib.sol
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ library RemainingInvalidatorLib {
revert RemainingInvalidatedOrder();
}
unchecked {
return value - 1;
return ~value;
}
}

Expand All @@ -54,7 +54,7 @@ library RemainingInvalidatorLib {
return orderMakerAmount;
}
unchecked {
return value - 1;
return ~value;

Check warning on line 57 in contracts/libraries/RemainingInvalidatorLib.sol

View check run for this annotation

Codecov / codecov/patch

contracts/libraries/RemainingInvalidatorLib.sol#L57

Added line #L57 was not covered by tests
}
}

Expand All @@ -66,7 +66,7 @@ library RemainingInvalidatorLib {
*/
function remains(uint256 remainingMakingAmount, uint256 makingAmount) internal pure returns(RemainingInvalidator) {
unchecked {
return RemainingInvalidator.wrap(remainingMakingAmount - makingAmount + 1);
return RemainingInvalidator.wrap(~(remainingMakingAmount - makingAmount));
}
}

Expand All @@ -75,6 +75,6 @@ library RemainingInvalidatorLib {
* @return result The remaining invalidator for a fully filled order.
*/
function fullyFilled() internal pure returns(RemainingInvalidator) {
return RemainingInvalidator.wrap(1);
return RemainingInvalidator.wrap(type(uint256).max);
}
}

0 comments on commit ca99b4c

Please sign in to comment.