Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(SC-940): Move extensions to separate folder #278

Merged
merged 4 commits into from
Oct 16, 2023
Merged

chore(SC-940): Move extensions to separate folder #278

merged 4 commits into from
Oct 16, 2023

Conversation

artall64
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
contracts/OrderLib.sol 100.00% <100.00%> (ø)
contracts/extensions/DutchAuctionCalculator.sol 100.00% <ø> (ø)
contracts/extensions/ERC1155Proxy.sol 0.00% <ø> (ø)
contracts/extensions/ERC721Proxy.sol 100.00% <ø> (ø)
contracts/extensions/ERC721ProxySafe.sol 0.00% <ø> (ø)
contracts/extensions/ETHOrders.sol 97.67% <ø> (ø)
contracts/extensions/ImmutableOwner.sol 100.00% <ø> (ø)
contracts/extensions/OrderIdInvalidator.sol 92.85% <ø> (ø)
contracts/extensions/PrioirityFeeLimiter.sol 0.00% <ø> (ø)
contracts/extensions/RangeAmountCalculator.sol 100.00% <ø> (ø)
... and 2 more

📢 Thoughts on this report? Let us know!.

galekseev
galekseev requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@galekseev galekseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, consider suggested description changes.
Perhaps, it makes sense to move OrderLib to libraries folder (discussible).

contracts/extensions/DutchAuctionCalculator.sol Outdated Show resolved Hide resolved
contracts/extensions/DutchAuctionCalculator.sol Outdated Show resolved Hide resolved
contracts/extensions/ETHOrders.sol Outdated Show resolved Hide resolved
contracts/extensions/WethUnwrapper.sol Outdated Show resolved Hide resolved
contracts/extensions/WethUnwrapper.sol Outdated Show resolved Hide resolved
contracts/libraries/AmountCalculatorLib.sol Outdated Show resolved Hide resolved
@artall64
Copy link
Member Author

@zZoMROT @galekseev pls check out lates changes on comments

@artall64 artall64 merged commit 97eff07 into master Oct 16, 2023
7 checks passed
@artall64 artall64 deleted the chore/sc-940-move-extensions-to-separate-folder branch October 16, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zZoMROT zZoMROT zZoMROT approved these changes

@galekseev galekseev galekseev approved these changes

@byshape byshape byshape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artall64 @zZoMROT @galekseev @byshape