Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build on FreeBSD #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the build on FreeBSD #43

wants to merge 1 commit into from

Conversation

asomers
Copy link

@asomers asomers commented Aug 22, 2024

  • some pam_sys constants are u32 on FreeBSD instead of i32.
  • The CONV_AGAIN and INCOMPLETE flags don't exist on FreeBSD, and weren't used in this crate. Remove them.
  • The Fail_Delay, XDisplay, XAuthData, and AuthTok_Type pam items types don't exist on FreeBSD, and aren't used in this crate, so remove them.
  • The Disallow_Null_AuthTok and PrelimCheck pam flags have the same value on FreeBSD as Establish_Cred. But they aren't actually used, so just remove them.
  • The Update_AuthTok pam flag has the same value on FreeBSD as Establish_Cred. But it isn't actually used, so just remove it.
  • The Change_Expired_AuthTok pam flag has the same value on FreeBSD as Reinitialize_Cred. But it isn't actually used, so just remove it.
  • Fix the drop_env_list function, which never worked (or even compiled) on non-Linux.

Fixes #42

* some pam_sys constants are u32 on FreeBSD instead of i32.
* The CONV_AGAIN and INCOMPLETE flags don't exist on FreeBSD, and weren't used
  in this crate.  Remove them.
* The Fail_Delay, XDisplay, XAuthData, and AuthTok_Type pam items types don't
  exist on FreeBSD, and aren't used in this crate, so remove them.
* The Disallow_Null_AuthTok and PrelimCheck pam flags have the same value on
  FreeBSD as Establish_Cred.  But they aren't actually used, so just remove
  them.
* The Update_AuthTok pam flag has the same value on FreeBSD as Establish_Cred.
  But it isn't actually used, so just remove it.
* The Change_Expired_AuthTok pam flag has the same value on FreeBSD as
  Reinitialize_Cred.  But it isn't actually used, so just remove it.
* Fix the drop_env_list function, which never worked (or even compiled) on
  non-Linux.

Fixes 1wilkens#42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken build on FreeBSD
1 participant