You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would love for us to have a WIP PR on the binderhub repo from the start, primarily to make sure we don't end up writing code that is not acceptable to be merged. The smaller the diffs, the better. However, we do not need to wait for those to first get merged before continuing testing.
For this specifically, I would suggest a traitlet that adds a conditional to not launch.
We are in agreement on the importance of getting feedback on the proposed change as quick as possible!
I ended up formulating this as a goal as I want to ensure that I can build the Dockerfile referencing a fork's branch meanwhile waiting for feedback and approval of the upstream PR.
I've opened jupyterhub/binderhub#1647 as a placeholder PR, and used my personal repo consideratio/binderhub as a fork - but the PR branch can be pushed to by jupyterhub/binderhub maintainers.
This is what's relevant to facilitate Dockerfile creation etc to unblock #3.
Update
Fork and development branch, together with a draft PR is now found at jupyterhub/binderhub#1647.
The text was updated successfully, but these errors were encountered: