Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a fork of binderhub to develop opt-out feature of not launching following build/push #6

Closed
consideRatio opened this issue Mar 23, 2023 · 5 comments
Assignees

Comments

@consideRatio
Copy link
Member

consideRatio commented Mar 23, 2023

Update

Fork and development branch, together with a draft PR is now found at jupyterhub/binderhub#1647.

@yuvipanda
Copy link
Member

Can you tell me what you mean by a 'fork' in this context?

@consideRatio
Copy link
Member Author

I mean a github repository fork of jupyterhub/binderhub to develop and trial the feature to upstream to jupyterhub/binderhub after success.

@yuvipanda
Copy link
Member

I would love for us to have a WIP PR on the binderhub repo from the start, primarily to make sure we don't end up writing code that is not acceptable to be merged. The smaller the diffs, the better. However, we do not need to wait for those to first get merged before continuing testing.

For this specifically, I would suggest a traitlet that adds a conditional to not launch.

@consideRatio
Copy link
Member Author

We are in agreement on the importance of getting feedback on the proposed change as quick as possible!

I ended up formulating this as a goal as I want to ensure that I can build the Dockerfile referencing a fork's branch meanwhile waiting for feedback and approval of the upstream PR.

@consideRatio
Copy link
Member Author

consideRatio commented Mar 24, 2023

I've opened jupyterhub/binderhub#1647 as a placeholder PR, and used my personal repo consideratio/binderhub as a fork - but the PR branch can be pushed to by jupyterhub/binderhub maintainers.

This is what's relevant to facilitate Dockerfile creation etc to unblock #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Archived in project
Development

No branches or pull requests

2 participants