Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to connect with a jupyterhub #82

Merged
merged 9 commits into from
Feb 12, 2024
Merged

Document how to connect with a jupyterhub #82

merged 9 commits into from
Feb 12, 2024

Conversation

yuvipanda
Copy link
Member

@yuvipanda yuvipanda commented Feb 7, 2024

I've only written the outline. It needs to be fleshed out, edited and tested.

Fixes 2i2c-org/infrastructure#3691

Copy link
Member

@sgibson91 sgibson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

README.md Outdated Show resolved Hide resolved
README.md Outdated

From now on, you can customize this JupyterHub as you would any other JupyterHub set up
using z2jh. The [customization guide](https://z2jh.jupyter.org/en/stable/jupyterhub/customization.html)
contains many helpful. In particular, you probably want to set up more restrictive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
contains many helpful. In particular, you probably want to set up more restrictive
contents may be helpful. In particular, you probably want to set up more restrictive

I think this is what this sentence is supposed to say?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or perhaps "contains many helpful examples"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks like my brain stopped mid sentence! "contains many helpful examples" is close, I pushed a change with something like that.

yuvipanda and others added 2 commits February 12, 2024 13:25
Co-authored-by: Sarah Gibson <44771837+sgibson91@users.noreply.github.com>
@yuvipanda yuvipanda merged commit 92a6ad2 into main Feb 12, 2024
2 checks passed
@damianavila damianavila deleted the connect-hub branch February 15, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

Document how to connect a JupyterHub to a binderhub with jupyterhub-fancy-profiles
2 participants