-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to connect with a jupyterhub #82
Conversation
33a3af7
to
fa75d98
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
README.md
Outdated
|
||
From now on, you can customize this JupyterHub as you would any other JupyterHub set up | ||
using z2jh. The [customization guide](https://z2jh.jupyter.org/en/stable/jupyterhub/customization.html) | ||
contains many helpful. In particular, you probably want to set up more restrictive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contains many helpful. In particular, you probably want to set up more restrictive | |
contents may be helpful. In particular, you probably want to set up more restrictive |
I think this is what this sentence is supposed to say?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or perhaps "contains many helpful examples"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, looks like my brain stopped mid sentence! "contains many helpful examples" is close, I pushed a change with something like that.
I've only written the outline. It needs to be fleshed out, edited and tested.
Fixes 2i2c-org/infrastructure#3691