Build docs separate #122
Merged
Build docs separate #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| raise ValueError('Usage: add_doc_to_wheel docs.zip snappy.whl') | ||
|
|
||
| python = sys.executable | ||
| tmp_dir = tempfile.mkdtemp() |
There was a problem hiding this comment.
with tempfile.TemporaryDirectory() as tmp_dir:
might be more pythonic. Not sure whether cleaning up the tmp directory at the end is a feature (making debugging easier) or bug.
There was a problem hiding this comment.
It was intended to make debugging easier.
| - uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: doc | ||
| path: /__w/SnapPy/SnapPy/doc_src/_build/doc/* |
There was a problem hiding this comment.
It might be a mess to download all that stuff. Would it be hard to install zip in the container temporarily?
There was a problem hiding this comment.
The upload-artifact action automatically puts the files in a single zipfile for easy download.
unhyperbolic
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the wheels with no docs and later use a separate script to build the docs. For the actual release, another script would “manually” insert the docs into the various snappy wheels (which are just zip files) before uploading to PyPI.