Small tweaks

3scale · Sep 19, 2024 · 1de699d · 1de699d
1 parent b979e95
commit 1de699d
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 8 deletions.
diff --git a/app/lib/event_store/active_record_event_repository.rb b/app/lib/event_store/active_record_event_repository.rb
@@ -5,7 +5,7 @@ class ActiveRecordEventRepository < RailsEventStoreActiveRecord::EventRepository
     def build_event_entity(record)
       return nil unless record
 
-      data = (record.data || {}).merge(
+      data = record.data.merge(
         event_id: record.event_id,
         metadata: record.metadata
       )

diff --git a/app/lib/three_scale/hash_hacks.rb b/app/lib/three_scale/hash_hacks.rb
@@ -24,22 +24,22 @@ def sweep
 
     # Convert all keys to lowercase.
     def downcase_keys
-      transform_keys { |key| key.downcase }
+      transform_keys(&:downcase)
     end
 
     # In place version of +downcase_keys+
     def downcase_keys!
-      transform_keys! {|key| key.downcase}
+      transform_keys!(&:downcase)
     end
 
     # Convert all keys to uppercase.
     def upcase_keys
-      transform_keys { |key| key.upcase }
+      transform_keys(&:upcase)
     end
 
     # In place version of +upcase_keys+
     def upcase_keys!
-      transform_keys! { |key| key.upcase }
+      transform_keys!(&:upcase)
     end
   end
 end
diff --git a/app/services/finance/billing_service.rb b/app/services/finance/billing_service.rb
@@ -73,7 +73,6 @@ def with_lock
 
     def report_error(error)
       message = "Failed to perform billing job: #{error.message}"
-      Rails.logger.error(message)
       System::ErrorReporting.report_error(error, error_message: message,
                                                  error_class: error.class.name)
     end

diff --git a/features/step_definitions/legal_terms_steps.rb b/features/step_definitions/legal_terms_steps.rb
@@ -6,5 +6,5 @@
 
 Given "{provider} has service subscription legal terms:" do |provider, text|
   provider.builtin_legal_terms.create!(system_name: CMS::Builtin::LegalTerm::SUBSCRIPTION_SYSTEM_NAME,
-                                      published: text)
+                                       draft: text)
 end
diff --git a/test/factories/cms.rb b/test/factories/cms.rb
@@ -82,6 +82,6 @@
   factory :cms_builtin_legal_term, :parent => :cms_builtin_partial, :class => CMS::Builtin::LegalTerm do
     system_name { 'signup_licence' }
     sequence(:title) { |n| "Legal Term ##{n}" }
-    published { "some text" }
+    draft { "some text" }
   end
 end