Pong: Socket 연결 및 게임 목록 기능 구현 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devleomk1
requested review from
Skyrich2000,
chichoon,
anso33,
ft-jasong and
stripy1026
Skyrich2000
reviewed
Feb 18, 2023
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
socket 연결 다 확인했으니까 ping pong 뺄까여 |
chichoon
previously approved these changes
Feb 18, 2023
Comment on lines
+7
to
+10
| const uuid = useLocation().pathname.split('/')[2]; | ||
| const gameRoomList = useRecoilValue(gameRoomListState); | ||
|
|
||
| const foundGameRoom = gameRoomList.find(gameRoom => gameRoom.id === uuid); |
Comment on lines
6
to
16
| joinChatRoomState, | ||
| leaveChatRoomState, | ||
| newChatRoomState, | ||
| newGamePingMessageState, | ||
| newMessageState, | ||
| updateChatRoomState, | ||
| joinGameRoomState, | ||
| newGameRoomState, | ||
| updateGameRoomState, | ||
| leaveGameRoomState, | ||
| } from 'store'; |
There was a problem hiding this comment.
와 이거 챗부분 이PR 머지되면 제가 나눠둘게요,,..
| setNewGameRoom({ | ||
| created: true, | ||
| }); | ||
| console.log('Click New Game Button\n'); |
| <button type="button" onClick={handleClickButton} className={gameRoomIconStyle}> | ||
| <PlusIcon /> | ||
| </button> | ||
| {isModalShown && ( | ||
| <Modal onClickClose={handleClickClose} className={newGameModalWrapperStyle}> | ||
| <header className={newGameModalHeaderStyle}> | ||
| <h4>새 게임</h4> | ||
| <h4>🐦 게임 만들기</h4> |
|
@Skyrich2000 @chichoon 올려주신 내용 수정해서 올렸습니다. |
|
console.log 발견 👀 |
Skyrich2000
reviewed
Feb 18, 2023
Comment on lines
+11
to
+15
| useEffect(() => { | ||
| return () => { | ||
| setLeaveGameRoom({ id: currentGameRoom.id }); | ||
| }; | ||
| }, []); |
Skyrich2000
reviewed
Feb 18, 2023
Comment on lines
3
to
6
| export const newGamePingMessageState = atom<string>({ | ||
| key: 'newGamePingMessageState', | ||
| default: '', | ||
| }); |
Skyrich2000
reviewed
Feb 18, 2023
| <div className={newGameFormStyle}> | ||
| <div className={newGameInnerDivStyle}> | ||
| <div className={formSectionDivStyle}> | ||
| <label htmlFor="new-chat-name">이름따위설정할수없다</label> |
Skyrich2000
reviewed
Feb 18, 2023
| exceptionHandler, | ||
| disconnectHandler, | ||
| }); | ||
| sockets.gameSocket.on('join_room', joinGameRoomHandler); |
There was a problem hiding this comment.
여기에
sockets.gameScoket.on('update_game_room', getAllGameRoomHandler); 빠진듯?
|
console.log 발견 👀 |
Skyrich2000
approved these changes
Feb 18, 2023
|
console.log 발견 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
게임 소켓 연결 및 게임 목록 기능을 구현 했습니다.