Upgrade to Python 3.11 #1852
Upgrade to Python 3.11 #1852
Conversation
…t failure of test_create_mapping.py::test_run_create_mapping_with_upgrader
| awscli = ">=1.25.36" | ||
| boto3 = "^1.26.133" | ||
| botocore = "^1.27.36" | ||
| python = ">=3.8.1,<3.12" |
There was a problem hiding this comment.
3.8.1 or 3.8? See my comments on cgap-portal.
There was a problem hiding this comment.
I didn't change that from master, it used to be: python = ">=3.8.1,<3.10" ... not sure why it would be 3.8.1 ...
(Same comment from cgap-portal ... and Will replied: I think I recall from a long time ago 3.8.1 has some specific issues with cgap-portal IRC hence the explicit exclusion)
pyproject.toml
Outdated
| @@ -32,23 +32,26 @@ classifiers = [ | |||
| # that you indicate whether you support Python 2, Python 3 or both. | |||
| 'Programming Language :: Python :: 3', | |||
| 'Programming Language :: Python :: 3.7', | |||
There was a problem hiding this comment.
Oversight, thanks, done.
| @@ -122,7 +122,7 @@ def anon_pipeline(): | |||
|
|
|||
|
|
|||
| def run(pipeline, inpath, outpath): | |||
| for item_type in ORDER: | |||
| for item_type in ORDER(): | |||
There was a problem hiding this comment.
I've made comments about this change to ORDER on other PRs. I really don't like this change.
There was a problem hiding this comment.
Oh shoot, I made that change in snovault, and in smaht-portal, but forgot to propagate to fourfront - will do - thanks.
There was a problem hiding this comment.
Made that change - not updated here - see the Files changed tab.
…om snovault which was renamed from ORDER
…t doing it for some reason.
No description provided.