Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update treatment item display title #1915

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update treatment item display title #1915

wants to merge 4 commits into from
+123 −5

Conversation

aschroed
Copy link
Member

  • Add 'override_treatment_title' property to Treatment items
  • Tweak the display_title calcprop to:
    • use the override_treatment_title prop if present
    • for biological treatments with constructs but no biological agent use construct names in treatment display_title
  • added tests

clarabakker
clarabakker reviewed Oct 30, 2024
View reviewed changes
src/encoded/types/treatment.py
[get_item_or_none(request, construct).get('display_title') for construct in constructs]
)
const_str = const_str.rstrip(", ")
disp_title = const_str + suffix + " treatment" + conditions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "treatment(s)" or a conditional to determine if it's one or more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarabakker clarabakker clarabakker left review comments

@RahiNav RahiNav Awaiting requested review from RahiNav

@dmichaels-harvard dmichaels-harvard Awaiting requested review from dmichaels-harvard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aschroed @clarabakker