Skip to content

Commit

Permalink
minor structured_data fix
Browse files Browse the repository at this point in the history
  • Loading branch information
dmichaels-harvard committed Mar 14, 2024
1 parent 6359cca commit 1dd7af7
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ Change Log
----------


8.8.2
=====
* Minor structured_data fix related to counting unresolved references;
not functionally consequential; only incorrect user feedback in smaht-submitr.


8.8.1
=====
* Changes to troubleshooting utility script view-portal-object.
Expand Down
4 changes: 3 additions & 1 deletion dcicutils/structured_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,9 @@ def ref_exists_internally(self, type_name: str, value: Optional[str] = None,
self._cache_ref(type_name, value, resolved)
return resolved
if update_counts:
self._ref_total_notfound_count += 1
# No do not update the not-found count if not found internally (2024-03-14).
# self._ref_total_notfound_count += 1
pass
return {} # Empty return means not resolved internally.

def _ref_exists_single_internally(self, type_name: str, value: str) -> Tuple[bool, Optional[dict]]:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "dcicutils"
version = "8.8.1"
version = "8.8.1.1b1" # TODO: To become 8.8.2
description = "Utility package for interacting with the 4DN Data Portal and other 4DN resources"
authors = ["4DN-DCIC Team <support@4dnucleome.org>"]
license = "MIT"
Expand Down

0 comments on commit 1dd7af7

Please sign in to comment.