Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.11 upgrade #279

Merged
merged 38 commits into from
Oct 5, 2023
Merged

Python 3.11 upgrade #279

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
7e142b1
Up pyyaml version to ^6.0.1 for Mac M1 issue with build.
dmichaels-harvard Aug 22, 2023
ece924a
Up pyyaml version to ^6.0.1 for Mac M1 issue with build.
dmichaels-harvard Aug 22, 2023
4a8f051
CHANGELOG changes.
dmichaels-harvard Aug 24, 2023
2e99cf7
Merge from master
dmichaels-harvard Aug 24, 2023
2f49bcb
version update
dmichaels-harvard Aug 25, 2023
829e5b0
Fix to test_s3_utils from kmp_sheet_utils_schema_hinting branch.
dmichaels-harvard Aug 25, 2023
53c8e6d
flake8 update
dmichaels-harvard Aug 25, 2023
69093fa
Merge from master
dmichaels-harvard Sep 20, 2023
6cc26bc
Update to Python 3.11!
dmichaels-harvard Sep 20, 2023
abe2140
Update to Python 3.11!
dmichaels-harvard Sep 20, 2023
a7fa068
Update boto3/botocore versions.
dmichaels-harvard Sep 20, 2023
669e51f
Update boto3/botocore versions.
dmichaels-harvard Sep 20, 2023
4b70bd2
CHANGELOG comments
dmichaels-harvard Sep 20, 2023
927862e
Update to Python 3.11
dmichaels-harvard Sep 20, 2023
702aedb
Remove Python 3.7 from pyproject and GA
dmichaels-harvard Sep 20, 2023
5b4c84b
Updated pip-licenses
dmichaels-harvard Sep 20, 2023
4120faa
Updated pip-licenses
dmichaels-harvard Sep 20, 2023
a25959b
update python to 3.9 in static-checks.yml
dmichaels-harvard Sep 20, 2023
07bbdd0
Removed pip from pyproject
dmichaels-harvard Sep 20, 2023
ba13cbf
Put pytest to latest version and added pytest-redis to ^3.0.2.
dmichaels-harvard Sep 21, 2023
7ed1511
Update version
dmichaels-harvard Sep 21, 2023
88f3b89
Updated boto versions.
dmichaels-harvard Sep 26, 2023
3e5cf5f
Updated boto versions.
dmichaels-harvard Sep 26, 2023
e24b3e0
Added Python 3.10, 3.11 to pyproject Python list
dmichaels-harvard Sep 28, 2023
c760707
Update Ubuntu to 22.04 for GA
dmichaels-harvard Sep 28, 2023
7b3daaf
Update Ubuntu to 22.04 for GA and poetry update
dmichaels-harvard Sep 28, 2023
099a32e
back out ubuntu to 22.04 for now to test - ga failing all of a sudden
dmichaels-harvard Sep 28, 2023
25a4b58
put back update to ubuntu 20.04 -> 22.04 for ga and see if ga fails now
dmichaels-harvard Sep 28, 2023
96cc528
ga failed with ubuntu 22.04 for python 3.11 - put back 20.04 to make …
dmichaels-harvard Sep 28, 2023
97f1173
put ubuntu 22.04 back for ga and add testing hack in qa_utils.py
dmichaels-harvard Sep 28, 2023
b226d61
flake8 error
dmichaels-harvard Sep 28, 2023
45064b2
more hacking of qa_utils for troubleshooting ga failure with ubuntu 2…
dmichaels-harvard Sep 28, 2023
bd6a797
Updated comments
dmichaels-harvard Sep 28, 2023
96a10cb
Fix to qa_utils for application/vnd.software602.filler.form+xml mime …
dmichaels-harvard Sep 28, 2023
af72ea9
Merged in master
dmichaels-harvard Sep 29, 2023
f7c05b5
poetry update
dmichaels-harvard Sep 29, 2023
27e11b6
Bumped to Python 3.11 in static-checks.yml
dmichaels-harvard Sep 29, 2023
2699a4d
Update version to 8.0.0; ready to merge to master.
dmichaels-harvard Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ dcicutils
Change Log
----------

7.10.0
======

* Changed PyYAML version to ^6.0.1; Mac M1 has issues building 5.4.1 (though 5.3.1 works).
See PyYAML 6.0 change log here: https://github.com/yaml/pyyaml/blob/master/CHANGES
The only incompatible change seems to be that yaml.load now requires a Loader argument;
and searching our repos (4dn-dcic, dbmi-bgm, smaht-dac) the only ones which might be affected
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
and searching our repos (4dn-dcic, dbmi-bgm, smaht-dac) the only ones which might be affected
and searching our GitHub organizations (4dn-dcic, dbmi-bgm, smaht-dac) the only ones which might be affected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

are cwltools and parliament2, neither of which are dependent on dcicutils in any way.

7.9.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a major version 8.0.0 would be wise, so that if there's an issue, it's easy for someone to use ^7.x. kinds of notation to select stuff that doesn't have this until a fix is ready. Probably not an issue, but that thing about change in required arg worries me.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willronchetti do you have an opinion on this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried about that required arg. I note that if you search for calls to yaml.load in 4dn-dcic (which is only one of our 3 orgs), you'll see several calls that don't pass an explicit Loader argument. Will that work or are you forcing code updates? Maybe those updates are fine. If there is an obvious loader, maybe we should have something that someone can call instead.

Copy link
Contributor Author

@dmichaels-harvard dmichaels-harvard Aug 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looking at those results as well as for dbmi-bgm and smaht-dac, I don't see any uses within a repo where dcicutils is used (where the version of pyyaml it uses will increments due to this dcicutils change). The only affected repos are cwltools and parliament2 - neither of which has any reference to dcicutils anywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built a cgap-portal(branch: dcicutils-with-pyyaml-6-and-sheet-utils | version: 14.2.0.1b1) with this dcicutils/pyyaml update and deployed to cgap-supertest and it seems fine (login/logout, create access-key, and ran submit-metadata-bundle).

=====
Expand Down
Loading
Loading