Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.11 upgrade #279

Merged
merged 38 commits into from
Oct 5, 2023
Merged

Python 3.11 upgrade #279

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
7e142b1
Up pyyaml version to ^6.0.1 for Mac M1 issue with build.
dmichaels-harvard Aug 22, 2023
ece924a
Up pyyaml version to ^6.0.1 for Mac M1 issue with build.
dmichaels-harvard Aug 22, 2023
4a8f051
CHANGELOG changes.
dmichaels-harvard Aug 24, 2023
2e99cf7
Merge from master
dmichaels-harvard Aug 24, 2023
2f49bcb
version update
dmichaels-harvard Aug 25, 2023
829e5b0
Fix to test_s3_utils from kmp_sheet_utils_schema_hinting branch.
dmichaels-harvard Aug 25, 2023
53c8e6d
flake8 update
dmichaels-harvard Aug 25, 2023
69093fa
Merge from master
dmichaels-harvard Sep 20, 2023
6cc26bc
Update to Python 3.11!
dmichaels-harvard Sep 20, 2023
abe2140
Update to Python 3.11!
dmichaels-harvard Sep 20, 2023
a7fa068
Update boto3/botocore versions.
dmichaels-harvard Sep 20, 2023
669e51f
Update boto3/botocore versions.
dmichaels-harvard Sep 20, 2023
4b70bd2
CHANGELOG comments
dmichaels-harvard Sep 20, 2023
927862e
Update to Python 3.11
dmichaels-harvard Sep 20, 2023
702aedb
Remove Python 3.7 from pyproject and GA
dmichaels-harvard Sep 20, 2023
5b4c84b
Updated pip-licenses
dmichaels-harvard Sep 20, 2023
4120faa
Updated pip-licenses
dmichaels-harvard Sep 20, 2023
a25959b
update python to 3.9 in static-checks.yml
dmichaels-harvard Sep 20, 2023
07bbdd0
Removed pip from pyproject
dmichaels-harvard Sep 20, 2023
ba13cbf
Put pytest to latest version and added pytest-redis to ^3.0.2.
dmichaels-harvard Sep 21, 2023
7ed1511
Update version
dmichaels-harvard Sep 21, 2023
88f3b89
Updated boto versions.
dmichaels-harvard Sep 26, 2023
3e5cf5f
Updated boto versions.
dmichaels-harvard Sep 26, 2023
e24b3e0
Added Python 3.10, 3.11 to pyproject Python list
dmichaels-harvard Sep 28, 2023
c760707
Update Ubuntu to 22.04 for GA
dmichaels-harvard Sep 28, 2023
7b3daaf
Update Ubuntu to 22.04 for GA and poetry update
dmichaels-harvard Sep 28, 2023
099a32e
back out ubuntu to 22.04 for now to test - ga failing all of a sudden
dmichaels-harvard Sep 28, 2023
25a4b58
put back update to ubuntu 20.04 -> 22.04 for ga and see if ga fails now
dmichaels-harvard Sep 28, 2023
96cc528
ga failed with ubuntu 22.04 for python 3.11 - put back 20.04 to make …
dmichaels-harvard Sep 28, 2023
97f1173
put ubuntu 22.04 back for ga and add testing hack in qa_utils.py
dmichaels-harvard Sep 28, 2023
b226d61
flake8 error
dmichaels-harvard Sep 28, 2023
45064b2
more hacking of qa_utils for troubleshooting ga failure with ubuntu 2…
dmichaels-harvard Sep 28, 2023
bd6a797
Updated comments
dmichaels-harvard Sep 28, 2023
96a10cb
Fix to qa_utils for application/vnd.software602.filler.form+xml mime …
dmichaels-harvard Sep 28, 2023
af72ea9
Merged in master
dmichaels-harvard Sep 29, 2023
f7c05b5
poetry update
dmichaels-harvard Sep 29, 2023
27e11b6
Bumped to Python 3.11 in static-checks.yml
dmichaels-harvard Sep 29, 2023
2699a4d
Update version to 8.0.0; ready to merge to master.
dmichaels-harvard Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
python_version: [3.7, 3.8, 3.9]
python_version: [3.8, 3.9, 3.11]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 3.10?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to save time in GitHub actions really; not sure 3.10 is in wide usage; can add if you like.


# Steps represent a sequence of tasks that will be executed as part of the job
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/static-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-python@v2
with:
python-version: 3.7
python-version: 3.9
- name: Python Package Setup
run: |
make configure
Expand Down
63 changes: 46 additions & 17 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ classifiers = [

# Specify the Python versions you support here.
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

]
Expand Down Expand Up @@ -70,7 +69,8 @@ coverage = ">=7.2.3"
# coveralls = ">=3.3.1"
flake8 = ">=3.9.2"
flaky = ">=3.7.0"
pip-licenses = "^3.5.5"
pip-licenses = "^4.3.3"
pip = "23.2.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would order this before pip-licenses, but that's minor.

Is it really a good idea to list pip here? Is poetry undoing the version we load in the Makefile? (In that case, maybe it is necessary to list it here. But it seems like something we may regret having to maintain.

Further, do you really mean to pin it to so specific a version? If so, could you add a comment saying why so we can know when to unpin it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I had that (pip) in there temporarily - I will remove it. Thanks.

pytest = ">=4.5.0"
pytest-cov = ">=2.7.1"
pytest-mock = ">=1.11.0"
Expand Down
Loading