Minor fix to misc_utils.to_integer (came up in structured_data handling of "17.0" in Doug's spreadsheet). #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmichaels-harvard
commented
Dec 12, 2023
•
dmichaels-harvard
commented
- Minor fix to misc_utils.to_integer to handle float strings.
- Minor fix to structured_data to accumulate unique resolved_refs across schemas.
Pull Request Test Coverage Report for Build 7387706682
💛 - Coveralls |
willronchetti
approved these changes
Dec 14, 2023
dcicutils/portal_utils.py
Outdated
Comment on lines
124
to
126
| @property | ||
| def key_id(self): | ||
| return self._key_id |
There was a problem hiding this comment.
There is some ambiguity here... KMS key? Portal access key? AWS key?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.