Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes related to submitr for date/time type and out-of-order references. #299

Merged
merged 21 commits into from
Feb 15, 2024

Conversation

dmichaels-harvard
Copy link
Contributor

  • Changes to structured_data support date/time types.
  • Changes to structured_data support internal references in any order.
  • New datetime_utils module and tests; first created for date/time support in structured_data.

@coveralls
Copy link

coveralls commented Feb 9, 2024

Pull Request Test Coverage Report for Build 7916248904

Details

  • -106 of 192 (44.79%) changed or added relevant lines in 8 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 73.775%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dcicutils/schema_utils.py 0 1 0.0%
dcicutils/data_readers.py 2 9 22.22%
dcicutils/datetime_utils.py 46 53 86.79%
dcicutils/portal_utils.py 30 45 66.67%
dcicutils/structured_data.py 0 31 0.0%
dcicutils/captured_output.py 0 45 0.0%
Files with Coverage Reduction New Missed Lines %
dcicutils/portal_utils.py 1 56.9%
dcicutils/structured_data.py 4 0.0%
Totals Coverage Status
Change from base Build 7787215842: -0.4%
Covered Lines: 10130
Relevant Lines: 13731

💛 - Coveralls

@dmichaels-harvard dmichaels-harvard merged commit f6d8ae4 into master Feb 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants