Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional bucket argument to s3_utils.read_s3 function. #318

Conversation

dmichaels-harvard
Copy link
Contributor

@dmichaels-harvard dmichaels-harvard commented Oct 4, 2024

  • Added optional bucket argument to s3_utils.s3Utils.read_s3 function (initially for Andy).

Copy link
Member

@aschroed aschroed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it - I was adding the same and happy to go with your version!

@coveralls
Copy link

coveralls commented Oct 4, 2024

Pull Request Test Coverage Report for Build 11197193215

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 75.622%

Totals Coverage Status
Change from base Build 10527583650: 0.004%
Covered Lines: 11437
Relevant Lines: 15124

💛 - Coveralls

@dmichaels-harvard dmichaels-harvard merged commit e3da7e7 into master Oct 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants