Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Protocol Specs] Metadata specs are not up-to-date with demo examples #50

Open
mmv08 opened this issue Oct 19, 2023 · 0 comments
Open

Comments

@mmv08
Copy link
Member

mmv08 commented Oct 19, 2023

The struct for plugin metadata from the demo doesn't match the specs:
https://github.com/5afe/safe-core-protocol-demo/blob/main/contracts/contracts/Base.sol#L18-L24

(There's a todo to add more examples, but not a todo to update the actual specs, so I'm creating this)

@rmeissner rmeissner changed the title Specs: the metadata specs are not up-to-date with demo examples [Protocol Specs] Metadata specs are not up-to-date with demo examples Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant