Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Add more tests for the safe apps signing feature #4061

Open
mmv08 opened this issue Aug 31, 2022 · 0 comments
Open

Add more tests for the safe apps signing feature #4061

mmv08 opened this issue Aug 31, 2022 · 0 comments
Labels
Safe Apps Tech-debt 🚧 Technical debt

Comments

@mmv08
Copy link
Member

mmv08 commented Aug 31, 2022 •
edited
Loading

Overview

As per @rmeissner suggestion, it'd be great if we had tests that check the correctness of the generated calldata

Requirements

Check if the generated transaction for the signMessage method equals the expected values (transaction recipient, data, value, hashing)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Safe Apps Tech-debt 🚧 Technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmv08