Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change Eldritch Blast damage to match Magic Missile #539

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

ASTRELION
Copy link
Contributor

What does this do?

Changes Eldritch Blast's damage to match the format of Magic Missile. I.e. Magic Missile lists damage rolls as per missile, even though you may cast multiple missiles. Eldritch Blast can also focus multiple targets or one like Magic Missile can, and the amount of blasts scale like Magic Missile does, so its damage should follow the same format. So, Eldritch Blast damage rolls are now per beam.

I'm not sure if there are more spells that operate similarly. Either way, I think they should all follow the same format.

I'd also like to informally suggest a new field for spells like this that defines how many times a spell is used per cast. So, for example, Eldritch Blast would have a field defining 1 beam at level 1, 2 beams at level 5, etc. I'm not sure if that's realistic, how many spells that impacts, or if it would be useful. I can open an actual issue for tracking that if it actually sounds useful to people.

How was it tested?

Built locally.

Is there a Github issue this is resolving?

No.

Did you update the docs in the API? Please link an associated PR if applicable.

N/A

Here's a fun image for your troubles

random photo - update me

@ASTRELION ASTRELION changed the title Change Eldritch Blast damage to match Magic Missile fix: Change Eldritch Blast damage to match Magic Missile Jul 20, 2023
Copy link
Collaborator

@bagelbits bagelbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I think you should open an issue for casts at character level to better capture this .

@bagelbits bagelbits merged commit 9171b22 into 5e-bits:main Jul 24, 2023
9 of 10 checks passed
@github-actions
Copy link

🎉 This PR is included in version 3.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ASTRELION
Copy link
Contributor Author

I opened issues for the new field suggested
Database issue: #541
API issue: 5e-bits/5e-srd-api#361

markpol pushed a commit to markpol/5e-database that referenced this pull request Oct 5, 2023
Change Eldritch Blast damage to match Magic Missile

Co-authored-by: ASTRELION <5625400-ASTRELION@users.noreply.gitlab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants