Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve reimbursement lists #222

Merged
merged 8 commits into from
Mar 20, 2024
Merged

Improve reimbursement lists #222

merged 8 commits into from
Mar 20, 2024

Conversation

raucao
Copy link
Member

@raucao raucao commented Mar 7, 2024 •
edited
Loading

  • Hide veto button for confirmed reimbursements
  • Show confirmation block for confirmed reimbursements (when details visible)
  • Hide expense line items by default for confirmed reimbursements, show/hide on click/tap (with hover indicator to discover)
  • Show date range of line items while collapsed

Screenshot from 2024-03-16 14-42-11

refs #221

@raucao raucao force-pushed the feature/reimbursement-lists branch from 49bd48c to af309ff Compare March 14, 2024 15:46
@raucao raucao changed the title WIP: Improve reimbursement lists Improve reimbursement lists Mar 14, 2024
@raucao raucao marked this pull request as ready for review March 14, 2024 18:28
galfert
galfert approved these changes Mar 20, 2024
View reviewed changes
app/components/reimbursement-item/template.hbs Outdated Show resolved Hide resolved
app/components/reimbursement-item/component.js Outdated Show resolved Hide resolved
raucao and others added 2 commits March 20, 2024 14:32
@raucao @galfert
Add correct role to interactive element
fc044df 
Co-authored-by: Garret Alfert <alfert@wevelop.de>
@raucao
Remove obsolete debug log
071922d
@raucao raucao merged commit 0777c21 into master Mar 20, 2024
3 checks passed
@raucao raucao deleted the feature/reimbursement-lists branch March 20, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galfert galfert galfert approved these changes

@bumi bumi Awaiting requested review from bumi

@silverbucket silverbucket Awaiting requested review from silverbucket

Assignees
No one assigned
Labels
kredits-2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raucao @galfert