Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimbursement form fixes and improvements #223

Merged
merged 7 commits into from
Mar 21, 2024

Conversation

raucao
Copy link
Member

@raucao raucao commented Mar 20, 2024

Fixes the wrong calculation for the BTC total when adding multiple line items, and adds integration tests to make sure something this facepalm-inducing doesn't happen again.

Other improvements:

  • Disable the "add" button on the budget overview, until a core contributor account is connected (so you don't notice after filling in the form and potentially have to do it again)
  • Automatically pre-select your own account as recipient, since it's the most likely one

@raucao raucao changed the title Fix calculation of BTC total in reimbursement form Reimbursement form fixes and improvements Mar 20, 2024
@raucao raucao merged commit b32f805 into master Mar 21, 2024
3 checks passed
@raucao raucao deleted the bugfix/220-reimbursement_sums branch March 21, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants