feat: awss3 DownloadFiles use backoff with 4xx error cancel

aws/awss3/awss3.go

@@ -328,16 +328,38 @@ func DownloadFiles(ctx context.Context, region awsconfig.Region, bucketName Buck
 			return nil, err
 		}
 		eg.Go(func() error {
+			ctx, cancel := context.WithCancel(ctx)
 			b := backoff.WithContext(backoff.NewExponentialBackOff(), ctx)
+			var gErr error
 			if err := backoff.Retry(func() error {
 				if _, err := downloader.Download(ctx, f, &s3.GetObjectInput{
 					Bucket: bucketName.AWSString(),
 					Key:    s3Key.AWSString(),
 				}); err != nil {
+					var oe *smithy.OperationError
+					if errors.As(err, &oe) {
+						var resErr *awshttp.ResponseError
+						if errors.As(oe.Err, &resErr) {
+							switch resErr.Response.StatusCode {
+							case http.StatusNotFound:
+								gErr = ErrNotFound
+								cancel()
+							case http.StatusBadRequest, http.StatusUnauthorized, http.StatusPaymentRequired,
+								http.StatusForbidden, http.StatusMethodNotAllowed, http.StatusUnprocessableEntity,
+								http.StatusMisdirectedRequest, http.StatusRequestURITooLong, http.StatusRequestEntityTooLarge,
+								http.StatusPreconditionFailed:
+								gErr = resErr.Err
+								cancel()
+							}
+						}
+					}
 					return err
 				}
 				return nil
 			}, b); err != nil {
+				if gErr != nil {
+					return gErr
+				}
 				return err
 			}
 			return nil

aws/awss3/awss3_test.go

@@ -353,6 +353,17 @@ func TestDownloadFiles(t *testing.T) {
 			}
 		}
 	})
+	t.Run("Error:BucketNotFound", func(t *testing.T) {
+		t.Parallel()
+		_, err := awss3.DownloadFiles(ctx, TestRegion, "NOT_FOUND", keys, t.TempDir())
+		assert.Error(t, err)
+	})
+	t.Run("Error:KeyNotFound", func(t *testing.T) {
+		t.Parallel()
+		dummyKeys := awss3.Keys{"dummy", "dummy", "dummy"}
+		_, err := awss3.DownloadFiles(ctx, TestRegion, TestBucket, dummyKeys, t.TempDir())
+		assert.Error(t, err)
+	})
 }
 
 func TestPutObject(t *testing.T) {