Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: awss3 DownloadFiles use PooledBufferedWriterReadFromProvider #254

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

tomtwinkle
Copy link
Contributor

@tomtwinkle tomtwinkle commented Aug 31, 2023

DL速度安定化のためにBufferProviderを指定する。
サイズはPartSizeに合わせる。

DefaultDownloadPartSize=1024*1204*5
DefaultPartBodyMaxRetries=3
DefaultDownloadConcurrency=5

https://zenn.dev/ichigo_dev/articles/2ff2ae3ce02e2a5f15da

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #254 (6d8f00a) into main (7d537c4) will increase coverage by 0.08%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   68.22%   68.31%   +0.08%     
==========================================
  Files          19       19              
  Lines        1067     1070       +3     
==========================================
+ Hits          728      731       +3     
  Misses        266      266              
  Partials       73       73              
Files Changed Coverage Δ
aws/awss3/awss3.go 74.57% <100.00%> (+0.21%) ⬆️

@tomtwinkle tomtwinkle merged commit a455008 into main Aug 31, 2023
5 checks passed
@tomtwinkle tomtwinkle deleted the feat/s3-download-use-pooled-buffered-wirter branch August 31, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant