Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: awss3 DownloadFiles use backoff #255

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

tomtwinkle
Copy link
Contributor

Use backoff to retry downloading a large amount of data because the rate limit will cause an error.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #255 (efea36e) into main (1ce7edc) will decrease coverage by 31.79%.
The diff coverage is 60.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##              main     #255       +/-   ##
============================================
- Coverage   100.00%   68.21%   -31.79%     
============================================
  Files            1       19       +18     
  Lines           40     1076     +1036     
============================================
+ Hits            40      734      +694     
- Misses           0      269      +269     
- Partials         0       73       +73     
Files Changed Coverage Δ
aws/awss3/awss3.go 74.15% <60.00%> (ø)

... and 19 files with indirect coverage changes

@tomtwinkle tomtwinkle merged commit 202019a into main Aug 31, 2023
5 checks passed
@tomtwinkle tomtwinkle deleted the feat/s3-download-use-backoff branch August 31, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant