Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go module update #363

Merged
merged 7 commits into from
Nov 22, 2023
Merged

go module update #363

merged 7 commits into from
Nov 22, 2023

Conversation

tomtwinkle
Copy link
Contributor

@tomtwinkle tomtwinkle commented Nov 21, 2023

The aws-sdk-go v2 is The endpoint mock used mainly for testing purposes did not work properly as it is because it was replaced by EndpointResolverV2 in the BREAKING CHANGE released on 11/15/2023.

aws/aws-sdk-go-v2#2370

The HostnameImmutable option of EndpointResolverWithOptionsFunc does not work with awss3 .
EndpointResolverWithOptionsFunc replaces staticResolver with endpoint mock.

This change in behavior causes the Client to always return the same thing when awss3 Mocked.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #363 (8e07e64) into main (972ba3b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #363   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         2    +1     
  Lines           40       138   +98     
=========================================
+ Hits            40       138   +98     

see 3 files with indirect coverage changes

@tomtwinkle tomtwinkle merged commit c01fcd5 into main Nov 22, 2023
6 checks passed
@tomtwinkle tomtwinkle deleted the enhancement/go-module-update branch November 22, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant