Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add material for generated SpriteMesh #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ochmar
Copy link

@Ochmar Ochmar commented Jan 14, 2024

I can't find any specific reason why don't we update Mesh with Material.
It makes it easier to preview and save.

@98teg
Copy link
Owner

98teg commented Jan 21, 2024

Hi! Thank you so much for taking the time. I'm not sure about this change though. In the case of an animation, every mesh shares the same material. By assigning it to each mesh, we would give the impression that the material of each mesh contains just a single frame of animation, which may cause some confusion. I would leave this open to gather more feedback.

@Ochmar
Copy link
Author

Ochmar commented Jan 22, 2024

Agreed, I did not think about animation.
I was thinking more of generating tons of SpriteMeshes that are static (not animated); hence pull request.
Do you think it'll make more sense to only use it with checkbox as a "setting"?
Something like "Add material to each mesh" (default false).
Or it does not make sense at all in this specific addon?

@98teg
Copy link
Owner

98teg commented Jan 25, 2024

It would be cool if each material contained only one frame, but that would require changing the UVs of the generated meshes. I'm not planning on adding this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants