Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootguard 1.0 support #346

Merged
merged 12 commits into from
Feb 1, 2023
Merged

Bootguard 1.0 support #346

merged 12 commits into from
Feb 1, 2023

Conversation

zaolin
Copy link
Collaborator

@zaolin zaolin commented Jan 12, 2023

  • Provisioning of bootguard 1.0
  • Merge of bg & cbnt provisioning tooling

@zaolin
Change package name for code unification
8fd8c79 
Signed-off-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
@zaolin
Switch to new fiano code base
59aba1d
@zaolin
initial commit
c383acb 
Signed-off-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
@zaolin
remove binaries
ac0b54a 
Signed-off-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
ChriMarMe
ChriMarMe approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@ChriMarMe ChriMarMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nits. error checking on all.

pkg/provisioning/bootguard/bootguard.go Outdated Show resolved Hide resolved
pkg/provisioning/bootguard/bootguard.go Outdated Show resolved Hide resolved
pkg/provisioning/bootguard/bootguard.go Outdated Show resolved Hide resolved
pkg/provisioning/bootguard/bootguard.go Outdated Show resolved Hide resolved
pkg/provisioning/bootguard/bootguard.go Outdated Show resolved Hide resolved
pkg/provisioning/bootguard/bootguard.go Outdated Show resolved Hide resolved
@zaolin
Fix ACM and command issues
e8c2163
@zaolin
Fix remaining build issues, update fiano, adapt acm usage
6f629b7 
Signed-off-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
@zaolin
Adapt CI scripts, READMEs and testdata script
0b83273 
Signed-off-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
@zaolin
Fix small nits
0cc577c 
Signed-off-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
@zaolin
Merge branch 'main' into bootguard-1.0
73920c7
@zaolin
More go mod updates
d88bf77 
Signed-off-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
@zaolin
Add missing error condition
e5c8f1f 
Signed-off-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
@zaolin
Fix ACM GetSize issues
f7f0d35 
Signed-off-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
flanfly
flanfly reviewed Feb 1, 2023
View reviewed changes
Copy link
Contributor

@flanfly flanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it's mostly renaming stuff.

cmd/bg-prov/README.md Show resolved Hide resolved
@zaolin zaolin merged commit b58fd49 into main Feb 1, 2023
@zaolin zaolin deleted the bootguard-1.0 branch February 1, 2023 11:19
@zaolin zaolin mentioned this pull request Mar 10, 2023
Closed
@ansiwen
Copy link

ansiwen commented Sep 4, 2023

I believe something important got lost here:
bg-prov: error: no Run() method found in hierarchy of bpm-gen-v-1 <bpm> <bios>

Also see #367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flanfly flanfly flanfly left review comments

@walterchris walterchris walterchris approved these changes

@xaionaro xaionaro xaionaro approved these changes

@ChriMarMe ChriMarMe ChriMarMe approved these changes

@rihter007 rihter007 Awaiting requested review from rihter007 rihter007 is a code owner

@trynity trynity Awaiting requested review from trynity trynity is a code owner

@marcoguerri marcoguerri Awaiting requested review from marcoguerri

@u1f35c u1f35c Awaiting requested review from u1f35c u1f35c is a code owner

@PatrickRudolph PatrickRudolph Awaiting requested review from PatrickRudolph PatrickRudolph is a code owner

@ArthurHeymans ArthurHeymans Awaiting requested review from ArthurHeymans ArthurHeymans is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zaolin @ansiwen @xaionaro @flanfly @ChriMarMe @walterchris