Basic generator #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR read, waiting returns |
arnaudgoulpeau
suggested changes
Oct 2, 2017
Util/ClassExtractor.php
Outdated
|
|
||
| $classes = static::findClasses($path); | ||
|
|
||
| if (\PHP_VERSION_ID >= 70000) { |
There was a problem hiding this comment.
Since this bundle requires PHP 7.1 I can even delete this check 👍 (Once again, it's just a copy from Symfony's repository)
| for ($i = 0; isset($tokens[$i]); ++$i) { | ||
| $token = $tokens[$i]; | ||
|
|
||
| if (!isset($token[1])) { |
There was a problem hiding this comment.
add a comment to explain what $token[1] is pls
| namespace A5sys\TypeScriptGeneratorBundle\Util; | ||
|
|
||
| /** | ||
| * Copied from by Symfony's ClassMapGenerator which is now deprecated |
There was a problem hiding this comment.
does it means this class is deprecated ? does the comment still apply ?
There was a problem hiding this comment.
Symfony's ClassLoader component (from which the class is copied) is deprecated. Since the class will be deleted in the next version of Symfony I have copy/pasted its code in our bundle to be able to use its functionality even when Symfony 4 will be released.
arnaudgoulpeau
approved these changes
Oct 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voici ma première version pour le générateur de code TypeScript à partir de classes PHP.
L'analyse des classes se base sur le composant Property Info de Symfony qui lui utilise la PHPdoc, les métadonnées Doctrine et le typage PHP pour déduire les informations sur les propriétés d'une classe.
Cette première version gère normalement les cas d'usages "basique" (je l'ai testé sur un petit projet) et il va falloir le tester sur un nombre plus conséquent d'entité pour trouver les cas limites et les corriger.
Il y a deux générateurs disponibles, un générateur d'interface ou de classes (les deux options semblent être utilisées dans le monde TypeScript, à confirmer). Les deux formats sont gérés par la même classe (et la même commande), la distinction se fait au niveau des services déclarés (je déclare plusieurs services à partir de la même classe).