Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django-oscar #6

Open
jayvdb opened this issue Dec 18, 2020 · 1 comment
Open

django-oscar #6

jayvdb opened this issue Dec 18, 2020 · 1 comment

Comments

@jayvdb
Copy link

jayvdb commented Dec 18, 2020

https://github.com/django-oscar/django-oscar views are all marked as "login required" = red, when they should almost all be detected as login required.

@kluchrj
Copy link
Contributor

kluchrj commented Dec 18, 2020

I'm not very familiar with django-oscar, but it seems that they use their own permission system that does not leverage the stock Django mixins and decorators (which is the only system this project supports out of the box).

To detect oscar views correctly, you would need to write your own permissions processor.

From my quick glance at the oscar code, they use their own permissions_required decorator that calls django's user_passes_test function (see this class for an example of how permissions auditor processes that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants