Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Media links to footer #146

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Social Media links to footer #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions _includes/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,16 @@
<div class="container">
<a href="mailto:abtech@andrew.cmu.edu" class="user-select-all">abtech@andrew.cmu.edu</a> |
<a href="tel:+14122682104" class="user-select-all">412.268.2104</a> |
<a href="https://tartanconnect.cmu.edu/feeds?type=club&type_id=68380&tab=about" target="_blank">TartanConnect</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a vertical bar after this entry like the others to match the formatting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, how does this look on mobile? Be mindful of how wide the line will be and if it may spill into the next line. You may choose to break the line somewhere depending on how it looks or move things around.

<a href="https://www.facebook.com/cmuabtech" target="_blank">
<img src="{{ '/assets/img/fb.png' | relative_url }}" width="18">
</a>
<a href="https://www.instagram.com/cmuabtech/?hl=en" target="_blank">
<img src="{{ '/assets/img/instagram-icon-white-on-black-circle.png' | relative_url }}" width="18">
</a>
<a href="https://www.tiktok.com/@cmuabtech?is_from_webapp=1&sender_device=pc" target="_blank">
<img src="{{ '/assets/img/tiktok_logo.png' | relative_url }}" width="18">
</a>
DaAwesomeP marked this conversation as resolved.
Show resolved Hide resolved
<br>
<span class="user-select-all" >CUC Box 73 | 5032 Forbes Ave | Pittsburgh, PA 15213</span> <br>
"Fly by night sound and light" since 1973. <br>
Expand Down
Binary file added assets/img/instagram-icon-white-on-black-circle.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/img/tiktok_logo.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.