Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to hh5, build new analysis3 to prepare access-nri-intake release #126

Merged
merged 7 commits into from
Nov 28, 2024

Conversation

rbeucher
Copy link
Member

No description provided.

@rbeucher
Copy link
Member Author

Using pip install for intake-ESM leads to:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
intake-thredds 2024.3.1 requires intake<2,>=0.6.6, but you have intake 2.0.7 which is incompatible.

@rbeucher
Copy link
Member Author

Actually, that's wrong intake-thredds is causing the issue.
@charles-turner-1, do we need it?
I am not sure I can remove it though...That env is supposed to replace hh5

@rbeucher
Copy link
Member Author

Intake has intake.readers.catalogs.THREDDSCatalogReader
Maybe it replaces intake-thredds?

@charles-turner-1
Copy link

I've had a look in all of the intake related environments (access-nri-intake-catalog, intake-dataframe-catalog, intake-esm) and I can't find intake-thredds in any of them, so I don't think it's being pulled in via the dependency tree of one of those.

I suspect it's probably fine to remove but I'm gonna do a bit more digging - I think it's worth finding out how it got included before we remove it.

Screenshot 2024-11-28 at 12 29 39 PM

@charles-turner-1
Copy link

Looks like an explicit requirement in environments/analysis3/environment.yml.

Since I can't see any dependencies on it, and grepping the python code for any references to open_thredds_cat or similar turns up nothing, I think we're safe to remove it.

@rbeucher rbeucher merged commit 0c009f0 into main Nov 28, 2024
4 checks passed
@rbeucher rbeucher deleted the remove_hh5 branch December 9, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants