Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge wombatlite + cable 3 changes into dev/preindustrial+concentrations #11

Conversation

blimlim
Copy link

@blimlim blimlim commented Dec 17, 2024

This PR brings in the changes needed to run ESM1.6 using wombatlite and cable3 into the dev/preindustrial+concentrations branch.

Changes include: updated namelists, new input files, and new restart files.

@blimlim blimlim force-pushed the dougiesquire/preindustrial+concentrations branch from c1af521 to 83ad4f1 Compare December 18, 2024 00:20
@blimlim blimlim requested a review from pearseb December 18, 2024 00:22
config.yaml Show resolved Hide resolved
@blimlim
Copy link
Author

blimlim commented Dec 18, 2024

@pearseb, I just noticed that the monthly 2d BGC surface fields section of the diag table yaml files don't have the module_name: generic_wombatlite line that the other wombat sections have. Should this be added in?

'monthly 2d BGC surface fields':
defaults: # these can be overridden for individual fields below
file_name_prefix: oceanbgc
file_name_dimension: 2d # descriptor for filename, e.g. 3d, 2d, scalar
output_freq: 1 # integer: output sampling frequency in output_freq_units (0: every timestep; -1: only at end of run)
output_freq_units: months # time units for output: years, months, days, hours, minutes, or seconds

config.yaml Show resolved Hide resolved
Copy link

@pearseb pearseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Spencer,
There are a few things that need correcting, but this can be done at a later date. It seems fine currently if we just want to get things running. I can also alter some of these files in my own local and push them back to the remote as I fix things.

@blimlim blimlim merged commit 44ac862 into dev-preindustrial+concentrations Dec 18, 2024
9 of 10 checks passed
@blimlim blimlim deleted the dougiesquire/preindustrial+concentrations branch December 18, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants