Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting_started/spack.md: provide instructions on updating #817

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

harshula
Copy link
Contributor

@harshula harshula commented Oct 1, 2024

No description provided.

@harshula harshula self-assigned this Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

PR preview
🛬 Preview link removed because the pull request was closed.

* Create directories to support multiple versions of Spack.
* Clone Spack with full context.
Copy link
Contributor

@atteggiani atteggiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @harshula for the PR.

Looks pretty good, just a few minor comments.

docs/getting_started/spack.md Outdated Show resolved Hide resolved
docs/getting_started/spack.md Outdated Show resolved Hide resolved
docs/getting_started/spack.md Outdated Show resolved Hide resolved
Copy link
Contributor

@atteggiani atteggiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks @harshula!

@harshula harshula merged commit d0f6913 into development Oct 2, 2024
7 of 8 checks passed
@harshula harshula deleted the harshula/update-spack branch October 2, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants