Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add units, input Nones for missing variable attrs #119

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

dougiesquire
Copy link
Collaborator

@dougiesquire dougiesquire commented Sep 28, 2023

This PR adds variable units attributes to the datastores and sets variable attributes to None when they are not available. Thus, the attributes for each variable can be determined from their index in the list.

cc @aidanheerdegen, @utkarshgupta95

Closes #120

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b891b5c) 97.31% compared to head (f91a2aa) 97.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   97.31%   97.16%   -0.15%     
==========================================
  Files           9        9              
  Lines         559      565       +6     
==========================================
+ Hits          544      549       +5     
- Misses         15       16       +1     
Files Coverage Δ
src/access_nri_intake/source/__init__.py 100.00% <100.00%> (ø)
src/access_nri_intake/source/builders.py 93.61% <ø> (ø)
src/access_nri_intake/source/utils.py 97.84% <83.33%> (-0.66%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougiesquire dougiesquire merged commit f46ab55 into main Sep 28, 2023
12 of 14 checks passed
@dougiesquire dougiesquire deleted the Nones_when_attrs_missing branch September 28, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add units to datastores
1 participant