Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ACCESS-OM3 builder #152
Add ACCESS-OM3 builder #152
Changes from 4 commits
1983bd2
69a43b4
bdf7f6b
bbd8b12
1f613a7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want a different realm for ocean-waves ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I don't know... The allowable vocab we have for realms atm follows CMIP6, which doesn't include a specific "waves" realm. We could add one, but that would require updating the schema, which is a little more work. The easiest route is just to say that ocean waves are part of the ocean (which is true I guess...).
But if you feel strongly, I'd be happy to add a
wave
realm?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The obvious advantage to having a
wave
realm is that you'd be able to filter the catalog for only products with wavesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel strongly at all, it feels like bigger question than this review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deferring to #155
Check warning on line 327 in src/access_nri_intake/source/builders.py
Codecov / codecov/patch
src/access_nri_intake/source/builders.py#L327
Check warning on line 331 in src/access_nri_intake/source/builders.py
Codecov / codecov/patch
src/access_nri_intake/source/builders.py#L331
Check warning on line 351 in src/access_nri_intake/source/builders.py
Codecov / codecov/patch
src/access_nri_intake/source/builders.py#L350-L351