Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity check notebook #305

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Add sanity check notebook #305

merged 4 commits into from
Dec 11, 2024

Conversation

marc-white
Copy link
Collaborator

Resolves #303 .

This PR adds a very basic sanity checking notebook for new catalog builds. It reports:

  • Current access-nri-intake-catalog version
  • Available catalog versions
  • Comparison between default catalog and a previous catalog
  • Rows, models and variables in catalog data sources

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (6782918) to head (c20b499).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files          11       11           
  Lines        1028     1028           
=======================================
  Hits         1009     1009           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@charles-turner-1 charles-turner-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I'd like to add some further automated checking, but thats a down the line issue.

@marc-white
Copy link
Collaborator Author

Looks good to me.

I'd like to add some further automated checking, but thats a down the line issue.

Stick that in a new issue - we can start collating a 'next release' actions list.

@marc-white marc-white merged commit 3590e46 into main Dec 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add 'sanity check' notebook for post-catalog build checks
2 participants