Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytest code and update CI to use model-config-tests repository #104

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

jo-basevi
Copy link
Collaborator

@jo-basevi jo-basevi commented Apr 29, 2024

The pytest code is being moved out to a separate repository: model-config-tests repository #103.

This PR:

  • Removes the test folder
  • QA checks use the model-config-tests repo

@jo-basevi jo-basevi changed the title Remove pytest code and update CI to use test-model-configs repository Remove pytest code and update CI to use model-config-tests repository Apr 29, 2024
@jo-basevi jo-basevi force-pushed the 103-Moving-test-code-to-model-config-tests branch from 5cbe307 to b6c261a Compare April 29, 2024 23:16
@jo-basevi jo-basevi marked this pull request as ready for review April 29, 2024 23:18
Copy link
Member

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the CI/CD portion - those would indeed reference the new repo correctly.
Looks so much better cleaned up :D

@jo-basevi jo-basevi force-pushed the 103-Moving-test-code-to-model-config-tests branch from b6c261a to 4b77752 Compare April 29, 2024 23:31
@jo-basevi
Copy link
Collaborator Author

Just had to amend my commit to verify it and fix a typo in commit message

@jo-basevi jo-basevi merged commit a57e7fd into main Apr 29, 2024
2 checks passed
@jo-basevi jo-basevi deleted the 103-Moving-test-code-to-model-config-tests branch May 13, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants