Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onion message test vector #2628

Merged
merged 5 commits into from
Apr 14, 2023
Merged

Onion message test vector #2628

merged 5 commits into from
Apr 14, 2023

Conversation

thomash-acinq
Copy link
Member

@thomash-acinq thomash-acinq commented Apr 11, 2023

Use latest test vector from the spec for onion messages (lightning/bolts#759).

Padding is an odd TLV and doesn't need any special treatment.
We now support adding any unknown TLV, not just padding.
remyers
remyers previously approved these changes Apr 13, 2023
Copy link
Contributor

@remyers remyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I reviewed the code/test and ran the test, seems solid.

@t-bast t-bast self-requested a review April 13, 2023 14:27
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thomash-acinq thomash-acinq merged commit 3973ffa into master Apr 14, 2023
@thomash-acinq thomash-acinq deleted the onion-message-test-vector branch April 14, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants