Remove bad returns in Syncing(Negotiating) (#699)

They were causing the inner function to return early and not prepend the `channel_reestablish`.
ACINQ · Sep 17, 2024 · 848b1bb · 848b1bb
1 parent e45bdc3
commit 848b1bb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/commonMain/kotlin/fr/acinq/lightning/channel/states/Syncing.kt b/src/commonMain/kotlin/fr/acinq/lightning/channel/states/Syncing.kt
@@ -244,7 +244,7 @@ data class Syncing(val state: PersistedChannelState, val channelReestablishSent:
                                     ChannelAction.Message.Send(state.localShutdown),
                                     ChannelAction.Message.Send(closingSigned)
                                 )
-                                return Pair(nextState, actions)
+                                Pair(nextState, actions)
                             } else {
                                 // we start a new round of negotiation
                                 val closingTxProposed1 = if (state.closingTxProposed.last().isEmpty()) state.closingTxProposed else state.closingTxProposed + listOf(listOf())
@@ -253,7 +253,7 @@ data class Syncing(val state: PersistedChannelState, val channelReestablishSent:
                                     ChannelAction.Storage.StoreState(nextState),
                                     ChannelAction.Message.Send(state.localShutdown)
                                 )
-                                return Pair(nextState, actions)
+                                Pair(nextState, actions)
                             }
                         is Closing, is Closed, is WaitForRemotePublishFutureCommitment -> unhandled(cmd)
                     }