Refactor swap-in trigger mechanism #483
Conversation
| @@ -774,6 +773,7 @@ class Peer( | |||
| nodeParams.liquidityPolicy.value.maybeReject(request.walletInputs.balance.toMilliSatoshi(), totalFee, LiquidityEvents.Source.OnChainWallet, logger)?.let { rejected -> | |||
| logger.info { "rejecting open_channel2: reason=${rejected.reason}" } | |||
| nodeParams._nodeEvents.emit(rejected) | |||
| input.send(WalletCommand.UnlockWalletInputs(request.walletInputs.map { it.outPoint }.toSet())) | |||
There was a problem hiding this comment.
I'm currently only unlocking utxos when funding attempts are rejected by our liquidity policy, but we could also unlock them if the funding fails later in the process, by having the corresponding channel state add a new action to unlock the inputs it was using. Do you think it's worth doing in this PR?
|
I could test this successfully. However the UX is still not optimal on Phoenix's side even with these changes, and since we are not able to test properly, I think the best course of action is to pause this PR and come back later, when we have more time. In the meantime, on Phoenix we can simply provide instructions that the app needs to be restarted. It's not ideal, but it's safe. |
That sounds reasonable. I removed the part where we retry on liquidity policy changes in a0b96b8: the PR is now a simple refactoring of the swap-in triggering mechanism, with the addition of unlocking utxos that were not used because of a liquidity policy rejection. I think we should merge this PR, as it lets us unit test the
What do you think? |
t-bast
changed the title
We create a new `SwapInManager` that checks the wallet state and decides whether to initiate a channel funding attempt, while keeping track of utxos that are currently being used. We allow unlocking those utxos once a channel funding attempt fails, which ensures that if we retry later (because another input is confirmed) we will reuse the previously failed inputs (instead of waiting for a restart to use them).
We create a new
SwapInManagerthat checks the wallet state and decides whether to initiate a channel funding attempt, while keeping track of utxos that are currently being used.We allow unlocking those utxos once a channel funding attempt fails because of a liquidity policy restriction.