Prevent deadlocks in Peer #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using BUFFERED channels, with the default behavior where the sender suspends when the buffer is full (64 elements by default). The issue is that the same coroutine receives from the `input` channel and emits potentially multiple events to that same channel. We would thus fill the buffer, which causes us to `suspend`, which stops dequeuing events, leading to a complete deadlock.
pm47
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using BUFFERED channels, with the default behavior where the sender suspends when the buffer is full (64 elements by default).
The issue is that the same coroutine receives from the
inputchannel and emits potentially multiple events to that same channel. We would thus fill the buffer, which causes us tosuspend, which stops dequeuing events, leading to a complete deadlock.