Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle feature-less BOLT 11 invoices #687

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Handle feature-less BOLT 11 invoices #687

merged 1 commit into from
Jul 15, 2024

Commits on Jul 15, 2024

  1. handle feature-less bolt11 invoices

    We were not handling correctly feature-less invoices, which are
    spec-compliant. We do reject invoices that don't have
    `var_onion_optin`, but the check happens later. Instead, we currently
    throw a `NullPointerException`.
    
    The way we are checking requirements in the `init` block requires
    lazy-init properties, otherwise the object initialization will fail
    before any logic can happen.
    
    Also, as per the spec, the feature tag must be skipped if there are no
    features enabled.
    pm47 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    6c49546 View commit details
    Browse the repository at this point in the history