Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ios) UI for claiming BIP353 address #602

Merged
merged 2 commits into from
Aug 8, 2024
Merged

(ios) UI for claiming BIP353 address #602

merged 2 commits into from
Aug 8, 2024

Conversation

robbiehanson
Copy link
Contributor

Mirrors changes in #585

Once an address is claimed, it shows up in the Receive screen:

@robbiehanson robbiehanson requested a review from dpad85 July 31, 2024 20:03
@robbiehanson
Copy link
Contributor Author

UI modifications:

  1. When the lightning address is available, we no longer display the raw offer
  2. The lightning address is copied with the ₿ prefix
  3. The lightning address is displayed with the ₿ prefix
  1. Tapping "copy" or "share" buttons now always displays the copy/share options sheet
  2. The "default" option is subtly displayed in bold

@robbiehanson robbiehanson mentioned this pull request Aug 2, 2024
Closed
dpad85
dpad85 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@dpad85 dpad85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@robbiehanson robbiehanson merged commit ff0b51f into master Aug 8, 2024
@robbiehanson robbiehanson deleted the ios-bip-353 branch August 8, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpad85 dpad85 dpad85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbiehanson @dpad85