Improve Import Performance #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2024 15:46
Signed-off-by: Andrew Vardeman <avardeman@agleader.com>
…roperties, simplify their instantiation, and use an array of SpatialValues in ISOSpatialRow for faster lookup Signed-off-by: Andrew Vardeman <avardeman@agleader.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We received a ~45MB ISOXML folder from case that took 54 minutes to import into our application (Ag Leader SMS) using the ISOv4Plugin. This seemed high, so I profiled the plugin and found several inefficiencies.
This PR replaces tree-searching and string comparisons in hot paths with dictionary and array lookups and integer comparisons. It took import time on the folder in question down to < 2min.
The changes diverge slightly from the patterns of LINQ usage seen through most of the code, but I think the performance gains are worth it.