Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build type override #5

Open
alaurenzi opened this issue Jun 29, 2021 · 4 comments
Open

Build type override #5

alaurenzi opened this issue Jun 29, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request [zube]: Backlog

Comments

@alaurenzi
Copy link
Contributor

Should be possible to override the build type from a recipe, e.g.

build:
  type: cmake
  args: 
    - -DDCMAKE_BUILD_TYPE=""
@alaurenzi alaurenzi added the enhancement New feature or request label Jun 29, 2021
@alaurenzi alaurenzi self-assigned this Jun 29, 2021
@alaurenzi
Copy link
Contributor Author

Should be true after 6b6ace5, to be tested @MarcoRuzzon

@MarcoRuzzon
Copy link
Collaborator

MarcoRuzzon commented Jul 7, 2021

this works as expected, DCMAKE_BUILD_TYPE in the recipe overrides the command line argument.

The problem is that this happens only if not cmake.is_configured() (line 41 6b6ace5), in fact only in this case the cmake_args is updated with options from command line arguments and recipe entries. Should line 41 also include force_configure as a condition?

@alaurenzi
Copy link
Contributor Author

My idea was to never change the cmake cache after it has been created.. I remember this used to cause a lot of confusion (and frustration) with the superbuild

@MarcoRuzzon
Copy link
Collaborator

So the only way to reconfigure a project would be to delete the cache. I agree that this is a nice practice. Maybe it could be useful to add tools to clear the cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request [zube]: Backlog
Projects
None yet
Development

No branches or pull requests

3 participants