Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GIF speed and don't use times below 20ms #269

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

dylwhich
Copy link
Collaborator

Description

Fixes screen recording GIFs playing back slowly due to using inconsistently supported 10ms frame times. Will occasionally drop frames from the GIF to ensure the timing is reasonably accurate even when the actual frame rate does not fit evenly within 10ms increments.

Test Instructions

Do some screen recordings, upload them to slack or open them in a browser, and see if they work OK and have the right playback speed. Check modes that have different frame rates also.

Ticket Links

Readiness Checklist

  • I have run make format to format the changes
  • I have compiled the firmware and the changes have no warnings
  • I have compiled the emulator and the changes have no warnings
  • I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
  • I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
  • I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

@AEFeinstein AEFeinstein merged commit 90f6d82 into main Aug 16, 2024
5 checks passed
@AEFeinstein AEFeinstein deleted the fix-gif-speed branch August 16, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants