Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create snapshot release with downloads when merging into main #272

Merged
merged 44 commits into from
Sep 7, 2024

Conversation

dylwhich
Copy link
Collaborator

@dylwhich dylwhich commented Sep 7, 2024

Description

  • The CI process was updated to automatically create a new github release called "snapshot" whenever changes are merged to main.
  • The Windows build now uses static pthread instead of linking against the shared libwinpthread-1, so including libwinpthread-1.dll in the artifact is no longer necessary!
  • Minor updates to documentation to reflect changes.
  • Finally using msys2 action with caching for Windows (I ended up switching the order of the firmware / emulator as suggested). Now it's almost a whole minute faster!

Test Instructions

Here's an example from my fork of what this will create: https://github.com/dylwhich/Swadge-IDF-5.0/releases/tag/snapshot.

Before merging, you can download the artifacts from the action (or from the last run on my fork) and check that all the files are there. You should be able to just unzip and double-click on any platform now!

Check the firmware to make sure everything is there.

Ticket Links

Readiness Checklist

  • I have run make format to format the changes
  • I have compiled the firmware and the changes have no warnings
  • I have compiled the emulator and the changes have no warnings
  • I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
  • I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
  • I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

@AEFeinstein
Copy link
Owner

I feel like there's a joke about double-zipping executables somewhere... It's silly, but a price I'm willing to pay.

There are a few CI warnings (mostly OSX), but I'm guessing you saw them and they don't matter?
image

@dylwhich
Copy link
Collaborator Author

dylwhich commented Sep 7, 2024

Ah yeah I think those errors are just like, we're installing stuff unnecessarily, which I think should be fine in case something isn't installed by default in the future.

@dylwhich dylwhich merged commit f38c864 into main Sep 7, 2024
6 checks passed
@dylwhich dylwhich deleted the create-latest-release-on-main branch September 10, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants