-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unduplicate frida_libpng fuzzer code using FridaRuntiemVec #2787
Unduplicate frida_libpng fuzzer code using FridaRuntiemVec #2787
Conversation
I wonder if the performance is different at all, since now there's dyn dispatch. I guess it shouldn't matter in practice, though |
good point, is there a convenient way to measure? |
also a possible way to tackle this is to have |
80532a7
to
968c473
Compare
An alternative option to this is #2792. |
Can you split the FridaRuntiemVec off and update the PR? Thanks :) |
Or even make this into a simple second example fuzzer? Either way |
closed in favor of #2799 |
making most of the code in
frida_libpng/fuzzer.rs
shared usingFridaRuntimeVec
, reduced the file from 494 lines to 274