Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document refactored tracing #936

Draft
wants to merge 8 commits into
base: maxgamill-sheffield/800-better-tracing
Choose a base branch
from

Conversation

ns-rse
Copy link
Collaborator

@ns-rse ns-rse commented Oct 9, 2024

Adds documentation, written by @MaxGamill-Sheffield, for...

  • Disordered tracing
  • Nodestats
  • Ordered tracing
  • Splining

I squashed the history of all the incremental commits that wrote this documentation but have left the changes I've made recently as individual commits.

Locally the advanced Table of Contentes (toctree) is not rendered, I need to check if this is the case on the GitHub CI rendered pages too though (which this PR should trigger).

NB Ideally this should be merged to maxgamill-sheffield/800-better-tracing before it is merged to main so the documentation and features arrive on main at the same time.

MaxGamill-Sheffield and others added 7 commits October 8, 2024 19:53
- Disordered tracing
- Nodestats
- Ordered tracing
- Splining
As per Markdown linting defined in `.markdownlint-cli2.yaml`

- Wrap lines at 120 characters.
- Fix all other linting errors automatically.
As per [myst docs](https://myst-parser.readthedocs.io/en/latest/syntax/optional.html#auto-generated-header-anchors)
setting the `myst_heading_anchors` sets the maximum depth for auto-generating label "slugs" for section headers.

Helps resolve some, but not all, complaints about internal links.
Myst-Parser complains about the use of Markdown footnotes (e.g. `[^1]`) therefore switch these to alternatives.
@MaxGamill-Sheffield
Copy link
Collaborator

MaxGamill-Sheffield commented Oct 9, 2024

@ns-rse you've requested a review, but this is still a draft, so are you happy with the toctrees?

Locally the advanced Table of Contentes (toctree) is not rendered, I need to check if this is the case on the GitHub CI rendered pages too though (which this PR should trigger).

And shall I re-examine the docs to ensure everything is rendered ok? (Also, how do I do this for CI and not local e.g. to see if the equations are loaded correctly?)

@ns-rse
Copy link
Collaborator Author

ns-rse commented Oct 9, 2024

Evening @MaxGamill-Sheffield

Not completely happy with toctrees but for some reason this hasn't triggered the build of the pages on CI which I was hoping for to help me see if its something with my local setup.

Its slightly obfuscated but the commands to replicate what CI does using sphinx-multidocs are in .github/workflows/sphinx_docs_to_gh_pages.yaml.

sphinx-multiversion . _build/html "../*setup*" "../*tests*" "../*.ipynb" ../demo.py ../make_baseline.py ../jupyter_notebook_config.py ../demo_ftrs.py

Weirdly using sphinx-build includes the new toctree but using sphinx-multiversion doesn't (it's essentially a wrapper which checks out each tag and runs sphinx-build on each tagged commit and maind and placing the output under _build/html/<tag|main> so that there are multiple versions of the documentation).

I add reviewers to drafts when creating them (so I don't forget when I hit the "Ready for review") but in this instance will see if making it "Ready for review" triggers the build.

If not and for expedience I will rejig how the advanced docs are linked from the front page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants