Adding CPU support in XPK #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoshaniN
commented
Jan 16, 2024
RoshaniN
force-pushed
the
xpk-cpu
branch
4 times, most recently
from
4ed211a
to
f0426ca
Compare
RoshaniN
force-pushed
the
xpk-cpu
branch
5 times, most recently
from
9c9b6e9
to
d5073b0
Compare
xuefgu
reviewed
Jan 29, 2024
There was a problem hiding this comment.
Shall we also document how to emulate multiple slices using a single CPU nodepool?
There was a problem hiding this comment.
Slices are emulated using Maxtext parallelism types, hence I think it would belong in Maxtext emulator for strorage documentation.
xuefgu
reviewed
Jan 29, 2024
RoshaniN
force-pushed
the
xpk-cpu
branch
2 times, most recently
from
6751dbc
to
759f0a6
Compare
Obliviour
reviewed
Feb 1, 2024
| --workload xpk-test-workload \ | ||
| --command="echo hello world" | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Description looks great!
Will you have a maxtext with xpk + cpu guide in the maxtext repo, if so can you link that here when ready?
There was a problem hiding this comment.
I plan to have the documentation in Maxtext emulator for storage at the moment, but can definitely build a guide in Maxtext soon.
xpk.py
Outdated
| # cluster_cpu_machine_type is being deprecated! | ||
| if args.cluster_cpu_machine_type != '': | ||
| xpk_print('Note that cluster-cpu-machine-type is deprecated,', | ||
| 'please use default-pool-cpu-machine-type instead!', |
There was a problem hiding this comment.
I like the message you used in the argument description:
Can we rephrase to:
'Note that `--cluster-cpu-machine-type` is deprecated,',
' Please use `--default-pool-cpu-machine-type={args.cluster_cpu_machine_type}` instead,'
' to denote the machine type of the default cpu node pool. Set'
' the machine type of other cpu nodepools using `--device-type`.'
Obliviour
reviewed
Feb 5, 2024
Obliviour
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Major changes:
Testing / Documentation
Tested cluster creation, CPU nodepool creation with args and env properly set.
Ran Maxtext workloads on CPUs using these changes.
Documented changes in README as well.
Verified that TPU training (with Maxtext workloads) run as expected.
[ y ] Tests pass
[ y ] Appropriate changes to documentation are included in the PR